Click here to go to the forum index Click here for the home page
 
Author Message

<  Bugs  ~  Repeating timers

Page 1 of 1
R2-D2
Posted: Fri Dec 12, 2008 9:46 pm Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
One of the first bugs I found in the firmware was for repeating timers. But as I don't use them and nobody has ever (in my memory) complained about them I've ignored the issue. But recently I've found a timestamp issue that is a bit widespread in the firmware, and a recent discussion with FireBird made me realise that repeating timers also have that problem, too.

The worst problem arises when the timer being updated is old (e.g. when the Toppy has been off for a while, or in the old days of failed timer wakeup). So the best way to show the issues is to set "old" timers. The following examples show the timer data that is added, followed by what it should become, and then what the Toppy actually turns it into:
Code:
Done at Fri 12/12/2008 20:15
---
Everyday  Fri 14-Nov 23:00-03:16 (256m)
should -> Fri 12-Dec 23:00-03:16 (256m)
   but -> Sat 13-Dec 23:00-00:00 (256m)
This shows how the wrong day can be selected because the firmware does not take into account the time. It also shows how this lengthy duration (256m) causes the timestamp bug to show up, with 3hrs 16mins being lost from the end time of the timer.
Code:
Weekend   Sun  9-Nov 23:00-03:16 (256m)
should -> Sat 13-Dec 23:00-03:16 (256m)
   but -> Mon 15-Dec 23:00-00:00 (256m)
This shows how the weekend updater can mess up and plonk the timer onto a weekday.
Code:
Weekly    Fri 14-Nov 23:00-03:16 (256m)
should -> Fri 12-Dec 23:00-03:16 (256m)
   but -> Fri 19-Dec 23:00-00:00 (256m)
Doesn't take into account the time, so ends up on the wrong week.
Code:
WeekDay   Mon 10-Nov 23:00-03:16 (256m)
should -> Fri 12-Dec 23:00-03:16 (256m)
   but -> Sat 13-Dec 23:00-00:00 (256m)
The weekday updater can also get the wrong day.

Is this worth trying to fix? Or does nobody actually use them?

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website
Andy K
Posted: Fri Dec 12, 2008 11:42 pm Reply with quote
Frequent contributor Joined: 14 Jun 2005 Posts: 3520
are you saying this bug is in 5.13.X ?
View user's profile Send private message
R2-D2
Posted: Sat Dec 13, 2008 12:34 am Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
Andy K wrote:
are you saying this bug is in 5.13.X ?
I didn't say, so by implication it's in most of them. In fact, pretty much all of them. Which means TF5800PVR-MHEG-Topfield-Sys_456-2005May10 through to 5.14.09+. And back to Jan 2005 on TF5000/TF5500 firmwares. Before that, the firmware may not have had repeating timers, I dunno. And I can't be bothered to check the handful from 2003 and 2004. Smile

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website
Andy K
Posted: Sat Dec 13, 2008 1:11 am Reply with quote
Frequent contributor Joined: 14 Jun 2005 Posts: 3520
It was only a question Wink

In any case 5.13.X doesn't go back any further than 2006 Razz (in the UK anyway)
View user's profile Send private message
gomezz
Posted: Sat Dec 13, 2008 1:39 am Reply with quote
Frequent contributor Joined: 18 Nov 2005 Posts: 3994 Location: Buckingham
R2-D2 wrote:
One of the first bugs I found in the firmware was for repeating timers. But as I don't use them and nobody has ever (in my memory) complained about them I've ignored the issue.

I have. Not sure from your decription how the bug you found manifests though.

_________________
TF5800, F/W: MS6 Recommended F/W 12/9/2009 -Sy+BmC0CbCfCtDEgEmEvEzIMPePsVdZ
TAPs: Power Down 0.75; QuickJump 1.72; MyStuff 6.6; TAP Commander 1.34; MyInfo B5.4; EPG2MEI v0.96;
Extend v1.7; EIT Sub v0.6; mei2archive BETA 3.8l6; Font Manager 1.0d; (Power Restore V0.7.3b)
View user's profile Send private message Visit poster's website
R2-D2
Posted: Sat Dec 13, 2008 10:26 am Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
gomezz wrote:
Not sure from your decription how the bug you found manifests though.
Long durations, and timers being updated not on the same day that the previous one fired (in normal operation this may be because it's close to midnight, or there's a clock glitch -- in the past the timer wakeup bug probably triggered it a lot).

So people can see for themselves, here's TestRep which tries to set three repeating timers (EveryWeekend, Weekly and WeekDay) for a time in the past that will trigger the bug (and the source code is included so you can see I'm not cheating!). These are all for 23:59 and 4hrs 16mins duration, to show all the issues. Once the timers are set, pop into the timer list and see if you agree with what the Toppy thinks is the "next" occurrence of that repeating timer. Note: most things won't show the corrupted end time of the timer, just the start time and duration (and maybe an end time calculated from that), so you'll have to take my word for this bit. Smile

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website
Iskra
Posted: Sat Dec 13, 2008 11:40 am Reply with quote
Regular contributor Joined: 28 Sep 2008 Posts: 28 Location: Northants; Tx:_SandyHeath
I have noticed noticed one manifestation of this bug, in that the Toppy seems to think that a Weekly recording starting at 23:57 on a Sunday clashes with a Weekday recording starting also at 23:57 & same channel.

I, for one, would be pleased to have it fixed. Smile
View user's profile Send private message
R2-D2
Posted: Sat Dec 13, 2008 12:49 pm Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
Iskra wrote:
the Toppy seems to think that a Weekly recording starting at 23:57 on a Sunday clashes with a Weekday recording starting also at 23:57 & same channel.
Clash resolution is a different matter, but it's also broken around the complexities of repeating timers, especially the ones that cross midnight.

[Rt] RepeatTimer should fix the update problems -- try TestRep after applying it. Due to the need to change the timestamp function, this is a "complex" patch which requires me to have a copy of your firmware in order for it to be supported (so if this patch doesn't apply you'll need to link me to your firmware and I can update it).

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website
Iskra
Posted: Sat Dec 13, 2008 8:29 pm Reply with quote
Regular contributor Joined: 28 Sep 2008 Posts: 28 Location: Northants; Tx:_SandyHeath
R2-D2 wrote:
Clash resolution is a different matter, but it's also broken around the complexities of repeating timers, especially the ones that cross midnight.


In case I wasn't clear, the example I gave shouldn't be a clash. The Toppy is being inconsistent in what it deems a Weekday. Setting 23:57 Weekday records Mon-Fri as expected & not Sunday. But in Timer Setting it reckons 23:57 Sunday to be a Weekday.
View user's profile Send private message
R2-D2
Posted: Sat Dec 13, 2008 9:19 pm Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
Iskra wrote:
In case I wasn't clear, the example I gave shouldn't be a clash.
Yes, I said it's broken, didn't I? It's the crossing midnight bit that confuses it the most -- since obviously that can cause a clash between weekday and weekend timers. Not sure I can be bothered to try to fix the (seemingly) 100s of different cases of this code that they've got though, for what is becoming quite clear that nobody really uses (probably everybody has the sensible set up with single-shot timers set by a text search).

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website
BeepHonkBeep
Posted: Sat Dec 13, 2008 11:48 pm Reply with quote
Frequent contributor Joined: 13 Jul 2006 Posts: 289
Hi R2D2

I'd not noticed this bug before, but I think I've just run into it myself tonight.

I've just found that a recording for Isolation on Film 4 produces a clash, yet I'm recording nothing else 'til approx 11am on Sunday, and have put this down to the bug you've highlighted.

If you could fix it I'd be grateful though it's not a problem that I've knowingly encountered often, if at all.

BhB

Edit
Not sure if this actually wasn't a MyStuff issue, as I'd set the film to record via CT with the boxing on itv4 still recording. I've managed to set the timer now by cancelling the CT and simply doing a single recording.

_________________
Hw: 2xTF5800 |500/160GB HD, new caps, int. fan |Slug - power always on
Fw: 5.13.65 AbB4BfBqCbCeCkCpCwCyDDeEcEfErEsEvFFsGmHHeKtNfOtPPcPsR0RaReRhRpRsSScSlSrStT2TdTeVbWfWsXpXw
Autostart TAPS: TAP Commander 1.32 |TF5000 Display 1.53 |Font Manager 1.0 |MHEG Control B1 |Standby 1.8 |eit2mei BETA 7.8m6 |SecCache (UK) 0.4 |Extend 1.6 |MyStuff 5.62b |mei2archive BETA 3.817
Other: WSS killer 2.10c |HDD Info 2.0 |Channel Manager 5.1 |Signal Monitor 0.52
View user's profile Send private message
R2-D2
Posted: Sun Dec 14, 2008 10:14 am Reply with quote
Frequent contributor Joined: 18 Dec 2006 Posts: 12148
BeepHonkBeep wrote:
Not sure if this actually wasn't a MyStuff issue, as I'd set the film to record via CT with the boxing on itv4 still recording.
That'll be it (especially if no repeating timers were involved... Smile). MyStuff is very (/too?) conservative when it comes to setting CT timers that clash with active recordings, but (as you discovered) you can set one-offs.

_________________
Troubleshooting -- User Manual -- Dark Side of the Matrix: Firmwares and Patches
View user's profile Send private message Visit poster's website

Display posts from previous:  

All times are GMT + 1 Hour
Page 1 of 1

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum